refactor: Media queries #2680
Merged
refactor: Media queries #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/dhx0dk5ua |
|
While we at it.. can we do something with those as well? Maybe two sizes is enough |
|
Maybe part of the dialog property? |
lipis
reviewed
Dec 27, 2020
| @@ -153,6 +154,8 @@ | |||
| } | |||
| } | |||
|
|
|||
| // move the lock button out of the way on small viewports | |||
| // it begins to collide with the GitHub icon before we switch to mobile mode | |||
| @media (max-width: 760px) { | |||
There was a problem hiding this comment.
can we get those in variables? 425/760
There was a problem hiding this comment.
Since they’re only used once and are fairly specific to the context I think it’s ok to use them as-is (with the comment that I added) and only pull them out if it becomes a problem
lipis
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2678