-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply initialData appState for zenmode and grid stats and refactor check param for actions #2871
Conversation
… from initialData appState fixes #2870
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/qp2wkb3fc |
I'm facepalming myself — didn't think of state persistence. That said, this fix won't do. Mixing action objects and functions returning action objects is introducing several problems: 1) it's not pretty 2) it's not performant (having to rebuild/register actions multiple times) 3) and since we don't type check the exported actions, it will be error prone. In fact, it already is: it breaks shortcut handling. I propose we change |
…and returns boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog?
@dwelle since we will anyways update the changelog as it's out of sync before we do the next version release so it will be easier to add at that time since this not an API change so the pr title can be used as it is in the changelog. (I pull all commits pushed after the last release and categorize it, will soon automate the categorizing then it will be easy to generate changelog). |
fixes #2870