Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use the latest version of Virgil #3124

Merged
merged 2 commits into from Feb 28, 2021
Merged

feat: Use the latest version of Virgil #3124

merged 2 commits into from Feb 28, 2021

Conversation

lipis
Copy link
Member

@lipis lipis commented Feb 26, 2021

Preview https://excalidraw-git-new-virgil-excalidraw.vercel.app

Source: https://github.com/excalidraw/virgil

  • Backwards compatibility with the old exported SVGs

@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/FXa3ayLWaNwTxTT5demViWXELBvH
✅ Preview: https://excalidraw-git-new-virgil-excalidraw.vercel.app

@lipis lipis marked this pull request as draft February 26, 2021 09:08
src/index-node.ts Outdated Show resolved Hide resolved
Copy link

@thorn0 thorn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it. It fixes a very important bug with the Cyrillic Д.

@thorn0
Copy link

thorn0 commented Feb 27, 2021

On the other hand, woff2 seems to look a bit worse on Windows (Windows 10) than ttf. 🤔

@dwelle
Copy link
Member

dwelle commented Feb 27, 2021

On the other hand, woff2 seems to look a bit worse on Windows (Windows 10) than ttf.

Don't see any difference on Windows 7/10. You may be seeing #2717 caused by different positioning/scroll on each of your scenes.

@thorn0
Copy link

thorn0 commented Feb 27, 2021

The difference is probably insignificant, but small font subjectively looks better to me on excalidraw.com than in this PR. It doesn't depend on focusing/selecting, so I don't think this is #2717.

image

@dwelle
Copy link
Member

dwelle commented Feb 27, 2021

Your pic on my screen looks better with the PR version (which doesn't mean anything), but I'm the last one to say "I'm not seeing it" since I was just unsuccessfully persuading a colleague that the text is blurry on low-DPI screens :).

@thorn0
Copy link

thorn0 commented Feb 27, 2021

The current version is a bit blurry, yes, but in a good way =)

Anyway, the Д fix is more important than this woff2 vs ttf issue. In the future, if possible, let's switch back to ttf.

@lipis
Copy link
Member Author

lipis commented Feb 28, 2021

Not a fontexpert.. but from a quick research.. woff2 seems like the latest and greatest, and has a smaller footprint. Maybe I messed up in the export (didn't have many options to be honest)..

https://caniuse.com/woff2

@thorn0
Copy link

thorn0 commented Feb 28, 2021

I'm not an expert either, so okay, let's use woff2. At least until we find an expert who can tell us the truth.

@dwelle
Copy link
Member

dwelle commented Feb 28, 2021

Let's do it!

@dwelle dwelle merged commit 0533538 into master Feb 28, 2021
@dwelle dwelle deleted the new-virgil branch February 28, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants