-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use the latest version of Virgil #3124
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/FXa3ayLWaNwTxTT5demViWXELBvH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it. It fixes a very important bug with the Cyrillic Д.
On the other hand, woff2 seems to look a bit worse on Windows (Windows 10) than ttf. 🤔 |
Don't see any difference on Windows 7/10. You may be seeing #2717 caused by different positioning/scroll on each of your scenes. |
The difference is probably insignificant, but small font subjectively looks better to me on excalidraw.com than in this PR. It doesn't depend on focusing/selecting, so I don't think this is #2717. |
Your pic on my screen looks better with the PR version (which doesn't mean anything), but I'm the last one to say "I'm not seeing it" since I was just unsuccessfully persuading a colleague that the text is blurry on low-DPI screens :). |
The current version is a bit blurry, yes, but in a good way =) Anyway, the Д fix is more important than this woff2 vs ttf issue. In the future, if possible, let's switch back to ttf. |
Not a fontexpert.. but from a quick research.. woff2 seems like the latest and greatest, and has a smaller footprint. Maybe I messed up in the export (didn't have many options to be honest).. |
I'm not an expert either, so okay, let's use woff2. At least until we find an expert who can tell us the truth. |
Let's do it! |
Preview https://excalidraw-git-new-virgil-excalidraw.vercel.app
Source: https://github.com/excalidraw/virgil