Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrap excalidraw in position relative & hide scrollbars in zen mode #3174

Merged
merged 7 commits into from Mar 6, 2021

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Mar 5, 2021

Tried other fixes for adjusting the UI but since the layer UI elements are on 4 corners of the canvas so adding position relative will be the safest fix so all elements are positions absolute to this container.

  • Wrap excalidraw in position relative so that host need not add it explicitly to fix positioning when non zero offsets
  • Hide scrollbars so it's not visible in zen mode
  • Remove overflow hidden from public/index.html since it's now handled in the excalidraw class

fixes #3143

Try it out here

TODOS

  • Update changelog
  • Release patch version

@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/iBpZNAH6T7htHFbnpEqxCqDmYN9q
✅ Preview: https://excalidraw-git-aakansha-pos-excalidraw.vercel.app

src/components/App.tsx Outdated Show resolved Hide resolved
@ad1992 ad1992 merged commit eb24e8f into master Mar 6, 2021
@ad1992 ad1992 deleted the aakansha-pos branch March 6, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excalidraw shouldn't require a container with stacking context
2 participants