Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't unnecessarily prompt when installing libraries #3329

Merged
merged 2 commits into from Mar 26, 2021
Merged

feat: don't unnecessarily prompt when installing libraries #3329

merged 2 commits into from Mar 26, 2021

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Mar 25, 2021 •
edited

fix #3327

This is relevant only when the tab is reused (#3320).

Upstream PR: excalidraw/excalidraw-libraries#84

@vercel
Copy link

vercel bot commented Mar 25, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/CyiEvLeqo2BoX3HTcnRa7SmgvHxM
✅ Preview: https://excalidraw-git-libscsrf-excalidraw.vercel.app

@dwelle dwelle requested a review from ad1992 March 25, 2021 20:33
@dwelle dwelle changed the title feat: prefer hash when importing libraries & expose importLibrary feat: don't unnecessarily prompt when installing libraries Mar 26, 2021
ad1992
ad1992 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 lets update the changelog/readme

@dwelle
Copy link
Member Author

dwelle commented Mar 26, 2021

looks good lets update the changelog/readme

Let's merge #3320 first.

@dwelle dwelle merged commit 30ae4b8 into master Mar 26, 2021
@dwelle dwelle deleted the libs_csrf branch March 26, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad1992 ad1992 ad1992 approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use CSRF token when installing libraries
2 participants
@dwelle @ad1992