Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: popover positioning #3399

Merged
merged 6 commits into from Apr 5, 2021
Merged

fix: popover positioning #3399

merged 6 commits into from Apr 5, 2021

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Apr 4, 2021 •
edited

fix #3394

  • Changed Popover fixed positioning to absolute.
  • Rewrote contextMenu to account for this change. As a side-effect, contextMenu now works properly when there are multiple excalidraw components on page.

@vercel
Copy link

vercel bot commented Apr 4, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/BtqAuKcdr4HFnasqKRBPEA8fhjHB
✅ Preview: https://excalidraw-git-fixpopoverpos-excalidraw.vercel.app

@dwelle dwelle mentioned this pull request Apr 4, 2021
Open
@dwelle dwelle merged commit 9733ecb into master Apr 5, 2021
@dwelle dwelle deleted the fix_popover_pos branch April 5, 2021 15:26
@SavvyShah SavvyShah mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad1992 ad1992 ad1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popover position incorrect on Safari for non-zero offsets/scroll
2 participants
@dwelle @ad1992