Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make history local to a given excalidraw instance #3481

Merged
merged 3 commits into from Apr 24, 2021
Merged

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Apr 24, 2021

An attempt to make history local to excalidraw instance so each component has its own history when multiple excalidraw rendered.

Try here

@vercel
Copy link

vercel bot commented Apr 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/34rDbduXoyC6RgasxrgwTwfKnPB1
✅ Preview: https://excalidraw-git-aakansha-history-excalidraw.vercel.app

@ad1992 ad1992 requested a review from dwelle April 24, 2021 08:46
@dwelle
Copy link
Member

dwelle commented Apr 24, 2021

Nice. What's up with the snapshot changes?

@ad1992
Copy link
Member Author

ad1992 commented Apr 24, 2021

Nice. What's up with the snapshot changes?

I have been checking about the same but looks like cleanup not happening correctly due to shared history, the only difference between the snapshots is now the snapshot with width 0 is removed but not sure why it was there earlier though.

@ad1992 ad1992 merged commit d310649 into master Apr 24, 2021
@ad1992 ad1992 deleted the aakansha-history branch April 24, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants