Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear LibraryUnit DOM on unmount #4084

Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix: clear LibraryUnit DOM on unmount #4084

merged 1 commit into from
Oct 22, 2021

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Oct 22, 2021

fix #4083

@vercel
Copy link

vercel bot commented Oct 22, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/7f8xyXbCfPAhe63haEJXSoqT57L7
✅ Preview: https://excalidraw-git-fixlibraryunmount-excalidraw.vercel.app

@dwelle dwelle requested a review from ad1992 October 22, 2021 18:48
@alexbarbato
Copy link

Just tested this functionally and looks great!

@dwelle dwelle merged commit 7dbd0c5 into master Oct 22, 2021
@dwelle dwelle deleted the fix_library_unmount branch October 22, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad1992 ad1992 ad1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library not fully clearing out all items on initial clear action
3 participants
@dwelle @alexbarbato @ad1992