feat: switch collab server

[dwelle]

No description provided.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/mnZsdAuiwNgTCadqKMMaJJ2938Cq
✅ Preview: https://excalidraw-git-switchcollabserver-excalidraw.vercel.app

[zsviczian]

@dwelle, I did fetch upstream and built the Obsidian Excalidraw package, but I get an error. If I revert this commit, then it builds OK.

[dwelle]

@zsviczian seems like a missing asset error? Unclear how it can be related to this PR that changes an env variable 🤔

[zsviczian]

I can just confirm my experience. When I reverted this commit, then build worked again. I’ll try it again tomorrow.

[ad1992]

This file is not involved when we publish the releases and hence @excalidraw/excalidraw-next was not published for this PR as well. @zsviczian have you made some changes in the fork in the way we publish the release ?

[zsviczian]

@ad1992: I've made changes to src/packages/excalidraw/webpack.prod.config.js to package everything into a single file because that is more efficient in Obsidian. But that should have nothing to do with the error above, since I was executing yarn build in the root directory, and not in the excalidraw package folder.

I kept the changes in my fork to the bare minimum (onDrop, onBeforeTextEdit, onBeforeTextSubmit and rawText field on Text element), otherwise my fork should be equivalent to master.

What sort of changes should I be looking for that may impact publish?

[ad1992]

@ad1992: I've made changes to src/packages/excalidraw/webpack.prod.config.js to package everything into a single file because that is more efficient in Obsidian. But that should have nothing to do with the error above, since I was executing yarn build in the root directory, and not in the excalidraw package folder.

I kept the changes in my fork to the bare minimum (onDrop, onBeforeTextEdit, onBeforeTextSubmit and rawText field on Text element), otherwise my fork should be equivalent to master.

What sort of changes should I be looking for that may impact publish?

Ok, that would be adding the webpack.optimize.LimitChunkCountPlugin({ maxChunks: 1 }) to package into a single file. This shouldn't affect anything. Since the assets are not found, could you make sure after the build command you have actually copied the excalidraw-assets folder to the obsodian plugin?

But that should have nothing to do with the error above, since I was executing yarn build in the root directory, and not in the excalidraw package folder.

You should execute it inside the package folder instead, running in root will try to build excalidraw app as whole.

[zsviczian]

I always build both the app and the package. I first build the Excalidraw app from root, then build the package from the package folder. In this case I didn't get to step two because I ran into the error building the Excalidraw app.

[ad1992]

I always build both the app and the package. I first build the Excalidraw app from root, then build the package from the package folder. In this case I didn't get to step two because I ran into the error building the Excalidraw app.

why do you need to build the app from root ? You are using your forked version of package right ? So then building app is not needed. yarn install in both root and package is needed.