Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop using production services for development #4113

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Oct 28, 2021

We don't want to be using production services when developing, for several reasons: database pollution; risk of accidental misuse, etc.

I've set up Firebase (Firestore & Storage) dev project, and we now also require spinning up your own collab server if needed (https://github.com/excalidraw/excalidraw-room#development).

JSON server (shareable links) will be done in later PR.

  • firebase
  • collab server
  • json server will be done later

@vercel
Copy link

vercel bot commented Oct 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/2gujwW2NpxFGVL864jQcu8PYJZpM
✅ Preview: https://excalidraw-git-usedevservers-excalidraw.vercel.app

@dwelle dwelle requested a review from lipis October 28, 2021 15:42
Copy link
Member

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one and I'll fix the JSON server

@dwelle dwelle merged commit f1202ad into master Oct 29, 2021
@dwelle dwelle deleted the use_dev_servers branch October 29, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants