Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hint around canvas panning #4159

Merged
merged 6 commits into from
Nov 1, 2021
Merged

feat: add hint around canvas panning #4159

merged 6 commits into from
Nov 1, 2021

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Nov 1, 2021

Many users don't know how to pan canvas. While we will add a separate pan tool shortly, we should nevertheless teach people how to move canvas in a more efficient way.

Added a hint around canvas panning, when a selection tool is active, but nothing is selected — the reasoning for the latter is we show specific hints when certain elements are selected (arrow, line...) or when doing some action while selection tool is active (resizing...). So it's best we don't show the canvas panning hint all the time as it'd not be consistent and to ensure the hint doesn't appear as related to selecting.

Not showing on Mobile. This will still show on tablets. We will need a better way to discern devices that don't have a keyboard or mouse attached. One way is to detect in which way the selection tool was selected (pointerType/keyboard) — we're already doing that for image tool, but we need to figure out a state management for this so it propagates to HintViewer.

image

@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/BsJVFi5fewWVn7hwis8SEu8vwnbd
✅ Preview: https://excalidraw-git-canvasdraghint-excalidraw.vercel.app

@dwelle dwelle merged commit 3369035 into master Nov 1, 2021
@dwelle dwelle deleted the canvas_drag_hint branch November 1, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants