feat: set package build target to es2017
#4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/7SS37ta7Pf62SEEf1EqhF5pebs8R |
ad1992
approved these changes
Dec 7, 2021
|
@dwelle lets add this under "Build" in changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
dist/before build because it seems webpack simply merges the build output, not removing the old chunks/assets generated from previous buildsmove to
es2017build target. We don't support browsers that don't support it anyway. Solves a recent regression where transpiling async/wait to regenerators was causing typeError issues. Haven't dug super deep to figure out what was the exact cause, but it just seems a compiler issue.add to changelog?