Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bound text not atomic with container when changing z-index #4414

Merged
merged 6 commits into from
Dec 17, 2021

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Dec 17, 2021

fixes #4407

@vercel
Copy link

vercel bot commented Dec 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/9qwgNQew2Zh4K2Pb5f3sPibvg149
✅ Preview: https://excalidraw-git-aakansha-layers-excalidraw.vercel.app

@ad1992 ad1992 requested a review from dwelle December 17, 2021 06:23
@dwelle
Copy link
Member

dwelle commented Dec 17, 2021

wait — we also need to do it from the other way around, when you select a different element and move it up/below.

@dwelle
Copy link
Member

dwelle commented Dec 17, 2021

The pushed commit should fix this:

excal-zindex-bound-text-fix

src/tests/zindex.test.tsx Outdated Show resolved Hide resolved
Co-authored-by: Aakansha Doshi <aakansha1216@gmail.com>
@dwelle dwelle changed the title fix: attach binded text when using layers fix: bound text not atomic with container when changing z-index Dec 17, 2021
@dwelle dwelle enabled auto-merge (squash) December 17, 2021 13:08
@dwelle dwelle merged commit 8b2b033 into master Dec 17, 2021
@dwelle dwelle deleted the aakansha-layers branch December 17, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Bring to front" action makes text disappear when text is bound to shape
2 participants