fix: set height correctly when text properties updated while editing in container until first submit

[ad1992]

Prev

Now

fixes #4461
This only happens for first time since text editor width is not yet set

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/J6XXoBA1ZymCsiYaw9WAiPPw7QqJ
✅ Preview: https://excalidraw-git-aakansha-prop-excalidraw.vercel.app

[zsviczian]

Why have the (almost) same code 4 times? Why not just change redrawTextBoundingBox like the below and leave the rest unchanged?

export const redrawTextBoundingBox = (element: ExcalidrawTextElement) => {
  let maxWidth;
  if (element.containerId) {
    const container = Scene.getScene(element)!.getElement(
      element.containerId,
    );
    maxWidth = container?container.width - PADDING * 2:undefined;
  }

....

[dwelle]

Why have the (almost) same code 4 times? Why not just change redrawTextBoundingBox like the below and leave the rest unchanged?

A good point, but we can't do that because the cloned element passed into redrawTextBoundingBox() doesn't yet have a <ExcalidrawElement, Scene> mapping.

[ad1992]

Why have the (almost) same code 4 times? Why not just change redrawTextBoundingBox like the below and leave the rest unchanged?

A good point, but we can't do that because the cloned element passed into redrawTextBoundingBox() doesn't yet have a <ExcalidrawElement, Scene> mapping.

Yep, other approaches could be to

1. Pass original element so scene could be derived inside redrawTextBoundingBox which probably is n't semantically correct API wise since purpose isn't clear.
2. Calculate the width of the DOM element which is not good perf wise and not needed after first submit at all