fix: prevent browser from scrolling when panning #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/3eMNYppE4XfDCxxT8Lmp61FaAaEv |
dwelle
commented
Dec 27, 2021
| @@ -1765,6 +1765,7 @@ class App extends React.Component<AppProps, AppState> { | |||
| if (event.key === KEYS.SPACE && gesture.pointers.size === 0) { | |||
| isHoldingSpace = true; | |||
| setCursor(this.canvas, CURSOR_TYPE.GRABBING); | |||
| event.preventDefault(); | |||
There was a problem hiding this comment.
technically we should prevent only when handleKeyboardGlobally == false, but for this use case it should be fine
|
changelog ? |
ad1992
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the component is inside a scrollable container, panning via
space-dragorwheel-dragcauses the container to scroll.