fix: disable contextmenu on non-secondary pen events or touch

[dwelle]

fix #4674

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/8Vk82LVYW4vfqSUhW1KXe1KCwP25
✅ Preview: https://excalidraw-git-disablecontextmenuforothertool-375984-excalidraw.vercel.app

[zsviczian]

This is a good improvement. I tested it on iPad with pencil and touch and on Samsung Note with touch and S-Pen. Works as expected.

Not related to this change... but do you have any idea why the context menu won't on a long press with the apple pencil, but does show with a long press with the S-Pen. This difference is the same for both the current excalidraw.com version and this PR.

[zsviczian]

What is the purpose of this?

event.nativeEvent.pointerType === "pen" &&
          event.button !== POINTER_BUTTON.SECONDARY

[dwelle]

Not related to this change... but do you have any idea why the context menu won't on a long press with the apple pencil, but does show with a long press with the S-Pen. This difference is the same for both the current excalidraw.com version and this PR.

Good catch. AFAIK iOS doesn't support touch-hold to open contextMenu, so we're detecting it manually. We should include pens in that. It also means this PR doesn't handle iOS touch — gonna fix. never mind, the check is downstream so it applies.

[dwelle]

What is the purpose of this?

event.nativeEvent.pointerType === "pen" &&
          event.button !== POINTER_BUTTON.SECONDARY

Allow opening contextmenu via the pen button that usually is used for opening contextmenus (it usually emits the same event.button type as right-click on a mouse).

I'll add a doc.

[dwelle]

50a67cc

this fix will require more work because of how it's implemented. I'll remove the commit for now as it actually needs timeout clearing which I'm not doing for pen. I'll open a new PR for this fix later.

[dwelle]

@zsviczian merging?