fix: reset unmounted state for the component #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/Gde2jBD6hx4w4H8zFvMo4nDbhjPH |
|
cc @ad1992 as it related to the embed component. |
rulikrulit
changed the title
|
@rulikrulit since this is related to the package, can you also update changelog under Fixes ? |
ad1992
approved these changes
Feb 1, 2022
|
merging 🎉, thanks @rulikrulit for fixing this! |
This was referenced Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Excalidraw is used as a dynamic component with useEffects it gets unmounted and mounted back multiple times.
componentWillUnmountsetsthis.unmountedtotruewhich breaks the functionality because it blockssyncActionResult. This fix ensures thatthis.unmountedis reseted to false