Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: penMode darkmode style #4692

Merged
merged 40 commits into from
Feb 2, 2022
Merged

Conversation

zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented Feb 2, 2022

This:
image

To this:
image

This reverts commit 8407268.
@zsviczian zsviczian requested a review from dwelle February 2, 2022 19:43
@vercel
Copy link

vercel bot commented Feb 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/5Y4porj6TFogfXFL7kRKgqupLMxp
✅ Preview: https://excalidraw-git-fork-zsviczian-fix-penmode-style-excalidraw.vercel.app

@dwelle dwelle merged commit 59cbf5f into excalidraw:master Feb 2, 2022
@dwelle
Copy link
Member

dwelle commented Feb 2, 2022

We should also set pointer-events: none for that. That said, still kinda a hack. (Maybe the menu positioning itself needs a rewrite.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants