feat: Make whole element clickable in view mode when it has hyperlink

[ad1992]

ScreenFlow.mp4

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/2cEFL6XzHYwePk8sNGhaFFLsteZR
✅ Preview: https://excalidraw-git-aakansha-link-view-excalidraw.vercel.app

[dwelle]

Cool. One thing: we should disable click-through if you drag between pointerdown and pointerup, if the drag distance is above some threshold (e.g. the DRAGGING_THRESHOLD we're using). Otherwise it will open links if you start dragging and release over a link. Can happen often when the links are on elements, not text.

(This affects edit mode as well, but to a much smaller degree since the clickable hitboxes are only the small icons.)

[ad1992]

DRAGGING_THRESHOLD

I am instead checking the pointer down and pointer up coords are exactly same as for click event it should be same then only redirect

[dwelle]

I am instead checking the pointer down and pointer up coords are exactly same as for click event it should be same then only redirect

exact match is too strict. I tend to make micro movements a lot when clicking using a mouse.

[ad1992]

I am instead checking the pointer down and pointer up coords are exactly same as for click event it should be same then only redirect

exact match is too strict. I tend to make micro movements a lot when clicking using a mouse.

But when its a click the pointer events will be same else it means that there was some movement?

[dwelle]

But when its a click the pointer events will be same else it means that there was some movement?

There is a tiny movement, yes. Hence the DRAGGING_THRESHOLD (10px), which we consider as unintentional.

[yeger00]

Hello,
Small question about this PR - what is the reason behind commit b21abd5 - disable the feature on mobile? It might make a difference for an app I'm working on, and I disabled it on a local branch and it seems to be working as expected.

Thanks,
Avi

[ad1992]

Hello, Small question about this PR - what is the reason behind commit b21abd5 - disable the feature on mobile? It might make a difference for an app I'm working on, and I disabled it on a local branch and it seems to be working as expected.

Thanks, Avi

@yeger00 the only reason for not making the element clickable in mobile was since there isn't any tooltip when you hover over the item so it might not be very intutive that it would open a link as soon as you click on it.
Would like to know your reasoning behind enabling it on mobile and based on that we can surely revisit this :)

[yeger00]

@ad1992 Thank you for your comment.
This is still a WIP, but I'm using Excalidraw as the platform to easily create "roadmap" for training. As an example, I'm working on some general "web development" roadmap here (and the code is here), but I plan to use it a training platform for newcomers in my work as well.
In this example, I patched both the "click" in mobile, and removed the blue icon for links (as suggested here).

Let me know what you think.
Thanks,
Avi