Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make link icon clickable in mobile #4736

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Feb 7, 2022

fixes #4704

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/Fv8bL6Wry3RGniC6C6oMWoNnsMqt
✅ Preview: https://excalidraw-git-aakansha-link-mobile-excalidraw.vercel.app

@ad1992 ad1992 marked this pull request as ready for review February 7, 2022 10:05
@ad1992 ad1992 requested a review from dwelle February 7, 2022 10:06
@ad1992 ad1992 merged commit 9be6243 into master Feb 7, 2022
@ad1992 ad1992 deleted the aakansha-link-mobile branch February 7, 2022 11:54
@zsviczian
Copy link
Collaborator

@ad1992, I am still not able to navigate to links on mobile, except by clicking on the element to invoke edit mode, and then clicking the link in the popup link editor… however this approach is far less than ideal, if you have an element with a link as part of a group.

Maybe this is down to precision of my touch and the other elements in the neighborhood. The link icon should have precedence and maybe a slightly larger (transparent) footprint.

@dwelle
Copy link
Member

dwelle commented Feb 7, 2022

@zsviczian can't reproduce. For me clicking on the icon works fine both in view and edit mode on mobile 🤔 — are you on latest?

@zsviczian
Copy link
Collaborator

I believe I am on the latest. I tried both this preview and on excalidraw.com with my iPad.

@dwelle
Copy link
Member

dwelle commented Feb 7, 2022

I believe I am on the latest. I tried both this preview and on excalidraw.com with my iPad.

Ok, you're right. I was checking just Android. #4740

@zsviczian
Copy link
Collaborator

I've now played with this in many different settings and devices. I am not sure what I am doing wrong, but I see no effect of this change on my iPad or on my Android. I am trying to tap on the link icon, I also tried with my pen hoping it would be more precise, but nothing.

The idea is I tap the blue link icon and the page opens? The only thing that works now is double-tapping the element, and the link editor comes up. There I can open the link. But this is not very convenient, especially if the element with the link is part of a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link icon not clickable on mobile
3 participants