Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contextMenu timer & pointers not correctly reset on iOS #4765

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Feb 9, 2022

Unclear why we're reimplementing event.touches list in the first place (maybe there's a valid reason), but that's for another day.

@vercel
Copy link

vercel bot commented Feb 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

excalidraw – ./

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/7XrgaEoR1iYeL5oijrhk2F1RLgHC
✅ Preview: https://excalidraw-git-fixiphonetouchend-excalidraw.vercel.app

excalidraw-package-example – ./src/packages/excalidraw

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-package-example/5wDdurjLCScWGpCLKB9ukt22CZv2
✅ Preview: https://excalidraw-package-example-git-fixiphonetouchend-excalidraw.vercel.app

Copy link
Contributor

@vjeux vjeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, it fixes the issue that completely broke the experience on iOS!

@dwelle dwelle merged commit 9653d67 into master Feb 9, 2022
@dwelle dwelle deleted the fix_iphone_touchend branch February 9, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants