Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: paste styles shortcut #4886

Merged
merged 5 commits into from Mar 9, 2022
Merged

fix: paste styles shortcut #4886

merged 5 commits into from Mar 9, 2022

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Mar 7, 2022 •
edited

fix #4884

the fix is 2 lines (actionDistribute.tsx). The rest are tests.

@vercel
Copy link

vercel bot commented Mar 7, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

excalidraw – ./

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/CYiaeayKXc51qqPL6Mc1CuGfLwzS
✅ Preview: https://excalidraw-git-fixpastestyles-excalidraw.vercel.app

excalidraw-package-example – ./src/packages/excalidraw

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-package-example/8hYKNqvf9j6CcVdRxYYxTTRXtkZx
✅ Preview: https://excalidraw-package-example-git-fixpastestyles-excalidraw.vercel.app

@dwelle dwelle mentioned this pull request Mar 7, 2022
Closed
@dwelle dwelle requested a review from zsviczian March 7, 2022 12:10
@zsviczian
Copy link
Collaborator

Looks good.
Probably subject to another PR, but currently copy/paste style for a sticky note will only update the container and not the text within the container.

2022-03-07.21-09-18.mp4

@dwelle
Copy link
Member Author

dwelle commented Mar 7, 2022

Probably subject to another PR, but currently copy/paste style for a sticky note will only update the container and not the text within the container.

Yes, let's fix that in another PR. I have one open from last year that improves style pasting in general.

ad1992
ad1992 approved these changes Mar 8, 2022
View reviewed changes
src/actions/actionStyles.test.tsx Outdated Show resolved Hide resolved
@dwelle @ad1992
Update src/actions/actionStyles.test.tsx
df803ff 
Co-authored-by: Aakansha Doshi <aakansha1216@gmail.com>
@dwelle dwelle merged commit 20de06e into master Mar 9, 2022
@dwelle dwelle deleted the fix_paste_styles branch March 9, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad1992 ad1992 ad1992 approved these changes

@zsviczian zsviczian zsviczian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paste Style does not work with keyboard shortcuts
3 participants
@dwelle @zsviczian @ad1992