Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Map shortcut O to ellipse and Add eraser shortcut E #4930

Merged
merged 5 commits into from Mar 16, 2022

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Mar 16, 2022

eraser-shortcut.mp4

@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

excalidraw – ./

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/GA43dAf2YdF5Etf6HPCJwJakyMcB
✅ Preview: https://excalidraw-git-aakansha-eraser-shortcut-excalidraw.vercel.app

excalidraw-package-example – ./src/packages/excalidraw

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-package-example/3gycK52E5ezaaA7GnmjxQQvBMqMQ
✅ Preview: https://excalidraw-package-example-git-aakansha-erase-9b65bc-excalidraw.vercel.app

@ad1992 ad1992 requested a review from dwelle March 16, 2022 08:49
@ad1992 ad1992 changed the title feat: Add erase shortcut Shift+E feat: Add eraser shortcut Shift+E Mar 16, 2022
@dwelle
Copy link
Member

dwelle commented Mar 16, 2022

I was actually thinking of using E for Eraser (align with Miro & tldraw), and remap Ellipse to O (align with Figma, Miro, tldraw).

@ad1992
Copy link
Member Author

ad1992 commented Mar 16, 2022

I was actually thinking of using E for Eraser (align with Miro & tldraw), and remap Ellipse to O (align with Figma, Miro, tldraw).

yep I actually wanted to do the same but was just worried if that would confuse users since we are using E for Ellipse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants