Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide trash button during collaboration #5037

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Apr 14, 2022

remove-delete.mp4

@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

excalidraw – ./

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/H2UfJJUYFWg8nxtWo6RgnkWyz9d7
✅ Preview: https://excalidraw-git-aakansha-hide-delete-excalidraw.vercel.app

excalidraw-package-example – ./src/packages/excalidraw

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-package-example/CykxxBLXJVMhMb45eYuRi3akv9cm
✅ Preview: https://excalidraw-package-example-git-aakansha-hide-delete-excalidraw.vercel.app

@ad1992 ad1992 requested a review from dwelle April 14, 2022 16:25
@dwelle
Copy link
Member

dwelle commented Apr 14, 2022

I'd only hide it visually so there's no jump. So using a combo of visibility: hidden & pointer-events: none, or replacing it with a placeholder that has the same width.

public/index.html Outdated Show resolved Hide resolved
@vjeux vjeux merged commit 52d10bb into master Apr 15, 2022
@vjeux vjeux deleted the aakansha-hide-delete branch April 15, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants