fix: propagate keydown events from excalidraw-wysiwyg inputs #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pomdtr
changed the title
pomdtr
changed the title
dwelle
reviewed
Apr 27, 2022
src/actions/manager.tsx
Outdated
Comment on lines
81
to
86
| if ( | ||
| event.target instanceof HTMLInputElement && | ||
| event.target.classList.contains("excalidraw-wysiwyg") | ||
| ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
actually shouldn't be necessary looking at it, since this is called only after we check that we're not in a writable element
There was a problem hiding this comment.
You are right, this is not necessary
dwelle
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These events are necessary from vscode side to fix: excalidraw/excalidraw-vscode#41
Here is a quick schema explaining the vscode logic: