Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Library load button does not work #5205

Merged
merged 2 commits into from May 18, 2022
Merged

Conversation

zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented May 18, 2022

fixes #5204

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw ✅ Ready (Inspect) Visit Preview May 18, 2022 at 7:45PM (UTC)
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 18, 2022 at 7:45PM (UTC)

@dwelle
Copy link
Member

dwelle commented May 18, 2022

Oh my, what a thing! Thanks for catching this!

I tweaked the code so that the import is awaited and it's also better to pass the fs promise to the updateLibrary directly.

@dwelle dwelle enabled auto-merge (squash) May 18, 2022 19:45
@dwelle dwelle merged commit 605aa55 into master May 18, 2022
@dwelle dwelle deleted the zsviczian-fix-librarynotloading branch May 18, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load library button broke at PR #5115
2 participants