Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy arrow head when using copy styles #5303

Merged
merged 3 commits into from Jun 14, 2022
Merged

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Jun 14, 2022

fixes #5297

copy-arrow-head.mp4

@vercel
Copy link

vercel bot commented Jun 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:49AM (UTC)
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jun 14, 2022 at 10:49AM (UTC)

src/actions/actionStyles.ts Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Jun 14, 2022

Took me a while to figure out why pasting arrowhead styles doesn't rerender. It's because we were mutating the original element since the first newElementWith() returned the orig one as there was no change to the generic properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrowheads aren't copied when using "copy styles"
2 participants