Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup renderScene #5573

Merged
merged 2 commits into from Aug 16, 2022
Merged

refactor: cleanup renderScene #5573

merged 2 commits into from Aug 16, 2022

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Aug 15, 2022

No description provided.

@vercel
Copy link

vercel bot commented Aug 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 10:23AM (UTC)
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 10:23AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Aug 15, 2022 at 10:23AM (UTC)

@ad1992 ad1992 marked this pull request as draft August 15, 2022 09:32
@ad1992 ad1992 changed the title refactor: split renderScene to a separate function and don't pass selectionElement refactor: cleanup renderScene Aug 15, 2022
@ad1992 ad1992 marked this pull request as ready for review August 15, 2022 11:15
@ad1992 ad1992 requested a review from dwelle August 15, 2022 13:02
@ad1992
Copy link
Member Author

ad1992 commented Aug 15, 2022

If merging this PR leads to any conflicts in open PR's, let me know. I would be happy to help.
cc @DanielJGeiger

@DanielJGeiger
Copy link
Collaborator

If merging this PR leads to any conflicts in open PR's, let me know. I would be happy to help. cc @DanielJGeiger

@ad1992 Thanks. I actually don't touch src/scene/renderScene.ts in #2993 and its derived PRs. From an initial read-through, the other changes here look like their impact on #2993 might be somewhat minimal.

@ad1992 ad1992 merged commit fd946ad into master Aug 16, 2022
@ad1992 ad1992 deleted the aakansha-cleanup branch August 16, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants