-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple elements resizing regressions #5586
fix: multiple elements resizing regressions #5586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
One more thing - does it matter if |
Do you mean whether element/point positions should be finite (non-Infinity)? I think it's a good idea if they are, yes :). Is there any specific reason why you're asking? |
Oh I meant integer, wrong word 😅 |
😂 No, it's fine if they're not. Back then we were rounding/flooring as mad (and we still may be in some cases, though the plan is to remove all of that where possible), but not anymore. So float away! |
c5bc125
to
c9beb7c
Compare
It would be great to get a review for this pr, thanks! |
This reverts commit 0981264080baf9637a9b893834318cb65a5de8a7.
if roughness is non 0 then bounds will be slightly different on each test run (for rounded linear element)
c9beb7c
to
58851e7
Compare
thank you! |
fix: multiple elements resizing regressions (excalidraw#5586)
MIN_FONT_SIZE
it stops updating and gets out of an element's bounds. It's hard to spot this issue because the last updated font size will be close to 1, unless the pointer is near the center of a selection while pressingalt
: