Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple elements resizing regressions #5586

Merged

Conversation

alex-kim-dev
Copy link
Contributor

@alex-kim-dev alex-kim-dev commented Aug 17, 2022

  • If the text size is getting less than MIN_FONT_SIZE it stops updating and gets out of an element's bounds. It's hard to spot this issue because the last updated font size will be close to 1, unless the pointer is near the center of a selection while pressing alt:
    Peek 2022-08-17 21-06
  • bound arrows not moving
  • element's width or height of zero
  • incorrect bounds for uncached linear elements

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 0:34AM (UTC)
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 0:34AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Oct 25, 2022 at 0:34AM (UTC)

@alex-kim-dev
Copy link
Contributor Author

One more thing - does it matter if x or y are finite or not?

@dwelle
Copy link
Member

dwelle commented Aug 18, 2022

One more thing - does it matter if x or y are finite or not?

Do you mean whether element/point positions should be finite (non-Infinity)? I think it's a good idea if they are, yes :).

Is there any specific reason why you're asking?

@alex-kim-dev
Copy link
Contributor Author

Oh I meant integer, wrong word 😅

@dwelle
Copy link
Member

dwelle commented Aug 18, 2022

Oh I meant integer, wrong word 😅

😂

No, it's fine if they're not. Back then we were rounding/flooring as mad (and we still may be in some cases, though the plan is to remove all of that where possible), but not anymore. So float away!

@alex-kim-dev
Copy link
Contributor Author

Should multiple elements selection be rotated like in case with a single element?
Peek 2022-08-24 10-17

@dwelle
Copy link
Member

dwelle commented Aug 24, 2022

Should multiple elements selection be rotated like in case with a single element? Peek 2022-08-24 10-17 Peek 2022-08-24 10-17

No, it should happen as you show in your gif — when elements are grouped, that is. When ungrouped, the common bounding box is not shown when rotating.

src/element/bounds.ts Outdated Show resolved Hide resolved
@alex-kim-dev
Copy link
Contributor Author

It would be great to get a review for this pr, thanks!

@dwelle
Copy link
Member

dwelle commented Oct 29, 2022

thank you!

@dwelle dwelle merged commit f5379d1 into excalidraw:master Oct 29, 2022
zsviczian added a commit to zsviczian/excalidraw that referenced this pull request Oct 29, 2022
fix: multiple elements resizing regressions (excalidraw#5586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants