fix: free draw flip not scaling correctly #5752
Conversation
Fixed freedraw flip by correctly calculating transform handle final point, to avoid scaling issues
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
adarkforce
changed the title
…o fix-freedraw-flip
Fixed lines elements by taking into account beizer curve bounds + fixed 2 point lines to appear flipped in place
|
Hi, @dwelle, I found out that there was also a problem with multi point line elements, in particular when the curve exceeded the min/max points, the element had an offset which was the difference between the last point and the end of the curve, as it can be seen in the video below: Registrazione.schermo.2022-10-16.alle.16.47.32.movAfter I managed to solve this issue, another minor issue arised: when roughness is > 1 the flipping is not pixel perfect but there is a slight imprecision due to the roughness expanding the line. As it can be seen in the video: Registrazione.schermo.2022-10-16.alle.16.44.04.mov |
There was a problem hiding this comment.
Thanks for the fixes @adarkforce, and sorry for the delay in review! Looking good 👍.
After I managed to solve this issue, another minor issue arised: when roughness is > 1 the flipping is not pixel perfect but there is a slight imprecision due to the roughness expanding the line. As it can be seen in the video:
You're right. Be it not for the bounding box, one wouldn't really notice it. I think we can live with that! :)
Alright, let's ship! 🚀
Fixed #5750 freedraw flip by correctly calculating transform handle final point, to avoid scaling issues