fix: cleanup redrawTextBoundingBox #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ad1992
changed the title
dwelle
reviewed
Apr 25, 2023
Comment on lines
-86
to
-92
| if (isArrowElement(container)) { | ||
| const centerX = textElement.x + textElement.width / 2; | ||
| const centerY = textElement.y + textElement.height / 2; | ||
| const diffWidth = metrics.width - textElement.width; | ||
| const diffHeight = metrics.height - textElement.height; | ||
| boundTextUpdates.x = centerY - (textElement.height + diffHeight) / 2; | ||
| boundTextUpdates.y = centerX - (textElement.width + diffWidth) / 2; |
There was a problem hiding this comment.
no its taken care in computeBoundTextPosition hence removed from here
There was a problem hiding this comment.
for more context it was fixed in computeBoundTextPosition in this PR - https://github.com/excalidraw/excalidraw/pull/6445/files
dwelle
approved these changes
Apr 25, 2023
This was referenced Nov 15, 2023
alswl
pushed a commit
to alswl/excalidraw
that referenced
this pull request
Nov 15, 2023
* chore: cleanup redrawTextBoundingBox * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.