perf: use UIAppState where possible to reduce UI rerenders
#6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
dwelle
commented
May 5, 2023
Comment on lines
+153
to
+154
| // FIXME once we split UI canvas from element canvas | ||
| appState as AppState, |
There was a problem hiding this comment.
This shouldn't matter now (as it's not actually any change in code, just types), and we will be splitting the canvas hopefully soon (the PR in in progress).
An alternative is to pass a getAppState() getter into LayerUI compo.
ad1992
approved these changes
May 8, 2023
|
🍉 |
This was referenced Nov 15, 2023
alswl
pushed a commit
to alswl/excalidraw
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes types: we are stripping (ignoring) some unused AppState props when memoizing LayerUI, but still had all the components operate with the full AppState. That means if we started using those props, it'd introduce stale state bugs.
And we make all the LayerUI compos use/subscribe on the actual AppState subset that we memoize on. This reduces rerenders.