fix: i18n: Apply Trans component to publish library dialogue #6564
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ad1992
changed the title
|
Thanks @Contextualist! Can we also do this for the We should also update the existing translations, consolidating the old strings into the new one, and sync back to Crowdin after we merge to |
Sure, done in 7bef66f
I tried to do an automated merge in bba9c00. Let me know if this is what you want. |
src/locales/ar-SA.json
Outdated
| "noteDescription": { | ||
| "pre": "", | ||
| "link": "مستودع المكتبة العامة", | ||
| "post": "ليستخدمها الآخرون في رسوماتهم." | ||
| }, | ||
| "noteGuidelines": { | ||
| "pre": "يجب الموافقة على المكتبة يدويًا أولاً. يرجى قراءة ", | ||
| "link": "الإرشادات", | ||
| "post": "" | ||
| }, | ||
| "noteLicense": { | ||
| "pre": "", | ||
| "link": "رخصة إم أي تي ", | ||
| "post": "وهو ما يعني باختصار أنه يمكن لأي شخص استخدامها دون قيود." | ||
| }, |
There was a problem hiding this comment.
I'm thinking we should not migrate RTL languages as it's likely significant that they didn't translate pre/post strings. Running it through a translator, it looks weird though, so I think it's best if people re-translate the whole string.
So let's revert the migrations for all RTL languages: ar-SA, fa-IR, he-IL.
There was a problem hiding this comment.
Got it, reverted in 10e2284
|
We're good to go, thanks @Contextualist! ❤️ |
This PR uses the Trans component introduced in #6534 to handle publish library dialogue translation entries. These entries need JSX to handle the embedded links. This PR supersedes #4268.