feat: recover scrolled position after Library re-opening #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Since we've reintroduced the skeleton here, can we try delaying the render by a ~100ms (e.g. via CSS opacity transition delay somehow) so we can avoid the flicked on initial open of cached library? Don't know if it'll look good, but we can try it out. |
previously, if closed while in throttle timeout, it would fire after it was closed and set the pos to invalid position
dwelle
approved these changes
May 31, 2023
|
@dwelle, thanks for the tweaks! Merging... |
This was referenced Nov 15, 2023
alswl
pushed a commit
to alswl/excalidraw
that referenced
this pull request
Nov 15, 2023
…6624) Co-authored-by: dwelle <luzar.david@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen the Library side panel and scroll to the same position as it was when closed. It also adds a skeleton placeholder, as it looks weird when the library is opened, scrolled down, and item content is still waiting to be rendered.