perf: Limiting the suggested binding to fix performance issue #6877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rahul3v
changed the title
rahul3v
changed the title
Limiting the binding to fix performance issue
rahul3v
changed the title
rahul3v
force-pushed
the
rahul3v-patch-1
branch
from
dfe75c7
to
dd2d7ba
Compare
rahul3v
changed the title
|
Good idea, I have noticed an issue with arrows performance too and another optimization I thought of to skip rendering of arrows which have opacity=0 and locked=true |
dwelle
approved these changes
Aug 14, 2023
|
Thanks @rahul3v! |
This was referenced Nov 15, 2023
alswl
pushed a commit
to alswl/excalidraw
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing #6262
Limiting the suggested binding to fix performance issue, for now to 50 (as discussed)
Root cause problem : on selection of multiple shapes containing arrows, on movement it starts comparing for binding with each arrows to shapes, leads to performance issue; which we here limit it to 50
Fix : when more than 50 shapes selected we skip binding comparing