Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DRY out and simplify setting active tool from toolbar #7079

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Oct 3, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Oct 3, 2023 10:09pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Oct 3, 2023 10:09pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 10:09pm

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 300.52 KB (-0.03% 🔽) 6.1 s (-0.03% 🔽) 893 ms (+0.4% 🔺) 7 s
dist/excalidraw-assets/locales 261.47 KB (0%) 5.3 s (0%) 431 ms (+75.62% 🔺) 5.7 s
dist/excalidraw-assets/vendor*.js 28.06 KB (0%) 562 ms (0%) 349 ms (-25.13% 🔽) 911 ms

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 73.54% / 70% 42966 / 58423
🟢 Statements 73.54% / 70% 42966 / 58423
🟢 Functions 69.61% / 68% 1368 / 1965
🟢 Branches 80.51% / 70% 5268 / 6543
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/types.ts 100% 100% 100% 100%
src/components/Actions.tsx 90.84% 95.23% 33.33% 90.84% 161-165, 248-251, 258-259, 282-285, 287-289, 302-305, 307-309, 329-330, 340-341, 406-414
src/components/App.tsx 74.89% 76.13% 72.22% 74.89% 407-408, 565-566, 593-653, 656-662, 665-668, 671-743, 746-765, 773-785, 790-791, 795-797, 816-918, 965-966, 978-979, 998-1000, 1016-1021, 1026-1071, 1076, 1094, 1103, 1110-1113, 1215-1221, 1307-1312, 1315-1343, 1346-1386, 1432-1433, 1451-1452, 1489-1490, 1494-1495, 1511-1518, 1523-1536, 1542-1543, 1548-1556, 1558-1566, 1578, 1612, 1669-1670, 1674-1679, 1683-1709, 1714-1715, 1748-1751, 1829-1831, 1893-1894, 1907-1910, 1915-1916, 1923-1924, 1930-1931, 1939-1940, 1943-1944, 1947-1950, 1953-1956, 1967-1975, 1980-1981, 2032-2033, 2047-2053, 2059-2067, 2071-2079, 2083-2084, 2087-2088, 2091-2092, 2095-2132, 2135-2147, 2158-2159, 2170-2171, 2182-2185, 2214-2221, 2224, 2226-2231, 2235-2237, 2252-2253, 2255-2264, 2289, 2295, 2334-2335, 2352-2354, 2376-2377, 2453-2454, 2459-2462, 2525, 2535-2553, 2556-2562, 2565-2566, 2572-2585, 2671-2672, 2674-2675, 2680-2682, 2707-2721, 2726-2745, 2760-2761, 2768-2769, 2802-2804, 2829, 2848-2852, 2863-2864, 2867-2871, 2873-2874, 2876-2879, 2904-2905, 2914-2916, 2918, 2993-2996, 3016-3018, 3028-3029, 3031-3051, 3068-3071, 3077-3080, 3090-3097, 3101-3102, 3107, 3126, 3131-3132, 3137-3138, 3166-3167, 3170-3171, 3179-3183, 3187-3197, 3202-3229, 3234-3245, 3304, 3330-3331, 3422, 3599-3600, 3603-3604, 3612, 3624, 3626-3627, 3668-3672, 3723-3729, 3735-3798, 3840, 3889, 3947, 3995-3998, 4001-4007, 4009-4012, 4027-4036, 4039-4040, 4124, 4126-4127, 4133-4135, 4137, 4146, 4168-4173, 4175-4178, 4182-4183, 4200-4201, 4205-4210, 4255, 4259-4266, 4273, 4283-4284, 4298-4299, 4350-4351, 4378-4379, 4408-4434, 4441-4442, 4465-4466, 4482, 4484-4485, 4501-4502, 4508-4509, 4513-4516, 4519-4520, 4535-4558, 4566, 4568-4569, 4623-4628, 4630-4632, 4648, 4650-4661, 4686-4689, 4748-4749, 4751-4774, 4789-4790, 4902-4931, 4996-5000, 5023-5024, 5044-5045, 5138, 5141-5145, 5168-5187, 5202, 5335, 5358-5407, 5459-5465, 5480-5482, 5536, 5586, 5621-5625, 5649-5675, 5711, 5713-5720, 5727-5730, 5743, 5766-5767, 5770-5771, 5803-5804, 5832-5833, 5915-5916, 5965-5978, 6041, 6113, 6131-6137, 6144-6147, 6170-6175, 6246-6249, 6255, 6270-6277, 6280-6287, 6343, 6417-6418, 6432-6434, 6437, 6451-6475, 6579-6598, 6608-6647, 6660-6661, 6670-6677, 6691-6703, 6716-6721, 6781-6799, 6803-6804, 6878-6882, 6889, 6891-6927, 6956, 7006, 7045-7050, 7052-7053, 7058-7089, 7099-7111, 7130-7131, 7137-7146, 7151, 7155-7159, 7168-7169, 7172-7177, 7181-7188, 7218, 7220-7224, 7226-7236, 7257-7265, 7269-7305, 7308-7376, 7384, 7402-7409, 7411-7427, 7442-7464, 7483-7485, 7530-7531, 7561-7562, 7578, 7652-7655, 7657-7673, 7675-7679, 7691-7692, 7702-7718, 7752-7753, 7757-7758, 7768, 7770-7773, 7775-7776, 7816, 7837-7838, 7864, 7867, 7907, 7918-7925, 7941-7942, 8025, 8046-8056, 8058-8068, 8099-8106, 8132-8133, 8174-8228, 8272-8273, 8276-8279, 8284-8285, 8306-8308, 8310-8314, 8352
src/components/LayerUI.tsx 85.41% 86.95% 52% 85.41% 284-287, 324-329, 373-418, 421-425, 432-440, 484-492, 498-501
src/components/MobileMenu.tsx 81.56% 40% 50% 81.56% 92-95, 140-145, 166-174, 186-194, 199-210
Generated in workflow #514

@dwelle dwelle merged commit 1f4f5e1 into master Oct 3, 2023
8 of 9 checks passed
@dwelle dwelle deleted the dwelle/refactor-tool-setting branch October 3, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant