Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bounds cached prematurely resulting in incorrectly rendered labels #7339

Merged
merged 1 commit into from Nov 24, 2023

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Nov 24, 2023

No description provided.

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Nov 24, 2023 6:49pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Nov 24, 2023 6:49pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 24, 2023 6:49pm

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 72.69% / 70% 45262 / 62267
🟢 Statements 72.69% / 70% 45262 / 62267
🟢 Functions 69.11% / 68% 1437 / 2079
🟢 Branches 80.96% / 70% 5683 / 7019
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/element/bounds.ts 83.41% 90.67% 89.28% 83.41% 180-261, 280-284, 307-308, 440-443, 488-489, 551-557, 566-568, 593-594, 619-630, 686-696, 729-732, 776-777
Generated in workflow #1138

@dwelle dwelle merged commit dd8a7d4 into master Nov 24, 2023
8 of 9 checks passed
@dwelle dwelle deleted the dwelle/fix-bounds-caching branch November 24, 2023 18:55
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 321.18 KB (+0.01% 🔺) 6.5 s (+0.01% 🔺) 694 ms (-7.81% 🔽) 7.2 s
dist/excalidraw-assets/locales 280.73 KB (0%) 5.7 s (0%) 262 ms (+59.93% 🔺) 5.9 s
dist/excalidraw-assets/vendor*.js 826.02 KB (0%) 16.6 s (0%) 1.8 s (+1.27% 🔺) 18.3 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant