-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose StoreAction
in relation to multiplayer history
#7898
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
07bc0a4
to
7f46b31
Compare
7f46b31
to
a04f6ac
Compare
…otential concurrency issues
a04f6ac
to
1f2cb61
Compare
StoreAction
in relation to multiplayer history
496a7e4
to
ce7fd9c
Compare
ce7fd9c
to
03c9075
Compare
@@ -3683,51 +3682,38 @@ class App extends React.Component<AppProps, AppState> { | |||
elements?: SceneData["elements"]; | |||
appState?: Pick<AppState, K> | null; | |||
collaborators?: SceneData["collaborators"]; | |||
commitToStore?: SceneData["commitToStore"]; | |||
storeAction?: SceneData["storeAction"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's note the default here? (as a tsdoc /** */
so it shows in intellisense)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, added
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Introduced breaking change in
updateScene
API due to the addedStore
component as part of the #7348. Specifically,sceneData
propertycommitToHistory: boolean
was replaced withstoreAction: StoreActionType
.Additional small improvements:
Store
methods, internal API & public API (i.e. introducedcommit
)updateScene
modifying store before already scheduled store actions executeAppState
in shared scenes (collab)