Increase resilience to generating large workbooks (#2320)

* Update xml-stream.js Increase resilience to generating large workbooks
exceljs · Sep 19, 2023 · 804775a · 804775a
1 parent 56a28e9
commit 804775a
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/lib/utils/xml-stream.js b/lib/utils/xml-stream.js
@@ -7,24 +7,19 @@ const OPEN_ANGLE = '<';
 const CLOSE_ANGLE = '>';
 const OPEN_ANGLE_SLASH = '</';
 const CLOSE_SLASH_ANGLE = '/>';
-const EQUALS_QUOTE = '="';
-const QUOTE = '"';
-const SPACE = ' ';
 
 function pushAttribute(xml, name, value) {
-  xml.push(SPACE);
-  xml.push(name);
-  xml.push(EQUALS_QUOTE);
-  xml.push(utils.xmlEncode(value.toString()));
-  xml.push(QUOTE);
+  xml.push(` ${name}="${utils.xmlEncode(value.toString())}"`);
 }
 function pushAttributes(xml, attributes) {
   if (attributes) {
+    const tmp = [];
     _.each(attributes, (value, name) => {
       if (value !== undefined) {
-        pushAttribute(xml, name, value);
+        pushAttribute(tmp, name, value);
       }
     });
+    xml.push(tmp.join(""));
   }
 }