Skip to content

Commit

Permalink
Merge pull request #728 from LesterLyu/fix-worksheet-state
Browse files Browse the repository at this point in the history
Read worksheet hidden state
  • Loading branch information
Siemienik committed Feb 18, 2019
2 parents 2b747cd + eb8814d commit 8fb94e9
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -238,7 +238,6 @@ var worksheet = workbook.getWorksheet(1);

```javascript
// make worksheet visible
worksheet.state = 'show';
worksheet.state = 'visible';

// make worksheet hidden
Expand Down
2 changes: 2 additions & 0 deletions lib/doc/workbook.js
Expand Up @@ -193,10 +193,12 @@ Workbook.prototype = {
var id = worksheetModel.id;
var name = worksheetModel.name;
var orderNo = value.sheets.findIndex(ws => ws.id === id);
var state = worksheetModel.state;
var worksheet = this._worksheets[id] = new Worksheet({
id: id,
name: name,
orderNo,
state,
workbook: this
});

Expand Down
Binary file added spec/integration/data/test-pr-728.xlsx
Binary file not shown.
22 changes: 22 additions & 0 deletions spec/integration/pr/test-pr-728.spec.js
@@ -0,0 +1,22 @@
'use strict';

var chai = require('chai');

var verquire = require('../../utils/verquire');

var Excel = verquire('excel');

var expect = chai.expect;

describe('github issues', function() {
it('pull request 728 - Read worksheet hidden state', function() {
var wb = new Excel.Workbook();
return wb.xlsx.readFile('./spec/integration/data/test-pr-728.xlsx')
.then(function() {
var expected = {1: 'visible', 2: 'hidden', 3: 'visible'};
wb.eachSheet(function(ws, sheetId) {
expect(ws.state).to.equal(expected[sheetId]);
});
});
});
});

0 comments on commit 8fb94e9

Please sign in to comment.