Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated tests failed on v8 even if they shouln't and there is lack of the newest node versions #2237

Closed
1 of 2 tasks
Siemienik opened this issue Apr 6, 2023 · 0 comments
Closed
1 of 2 tasks

Automated tests failed on v8 even if they shouln't and there is lack of the newest node versions #2237

Siemienik opened this issue Apr 6, 2023 · 0 comments
Assignees
@Siemienik
Labels
enhancement

Comments

@Siemienik
Copy link
Member

Siemienik commented Apr 6, 2023 •
edited

馃悰 Bug Report

According to pipeline: https://github.com/exceljs/exceljs/actions/runs/4624587709 / https://github.com/exceljs/exceljs/actions/runs/4624587709/jobs/8179721427

  1. The tests on node v8 failed. That's a pretty old node version, but still, I would like to keep tests passing as they always pass.
    image

  2. Node has been released also under versions 18 and 19 which are not covered with tests. I'm going to increase the test coverage.
    image

Meantime, I've just lost my job, and have got a little bit more time than usual. I'm going to put my free-run work into exceljs and some other open-source projects. The current progress I will discuss on my new Discord server: https://discord.com/invite/zUQKcUKS. Let's join the community and lead me to a most important part of exceljs where can I improve.
You can also support me by 鉂わ笍 GH Sponsors
@Siemienik Siemienik self-assigned this Apr 6, 2023
@Siemienik Siemienik mentioned this issue Apr 6, 2023
Merged
@Siemienik Siemienik mentioned this issue Apr 13, 2023
Merged
Siemienik added a commit that referenced this issue Apr 13, 2023
@Siemienik
#2237 : Update CI Tests, Drop support for Node v8 (#2242)
c228180 
FEAT #2237

In this PR:
* Added node versions 18 and 19 to the tests suite
* Drop node v8 tests
@exceljs exceljs locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Siemienik Siemienik

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Siemienik