Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White text and borders being changed to black #290

Closed
Rycochet opened this issue Mar 16, 2017 · 4 comments
Closed

White text and borders being changed to black #290

Rycochet opened this issue Mar 16, 2017 · 4 comments

Comments

@Rycochet
Copy link
Contributor

Might be related to #261

In Excel: change a cell colour to anything that it'll show up on, then change the text colour and border to (pure) white.

Saving from ExcelJS changes all the white text and border colours to black (I'd guess some default matching going on there). Other colours work normally.

Not checked against fill / patterns.

@guyonroche
Copy link
Collaborator

How Bizarre! I've reproduced this and the effects are weird.
I'll start looking into it straight away - apparently some colour management magic that I've missed.
Thanks for the heads up

@Rycochet
Copy link
Contributor Author

Can confirm that you've fixed it in c51811a - that looks painful!! Will leave this open till you push a release :-)

@guyonroche
Copy link
Collaborator

@Rycochet - I've just published 0.4.2 which should fix this (and the other) issues.
Turned out to be a combination of two things. First - I wasn't rendering theme="0" properly, and second - if you read one excel file, there's no guarantee that the default theme file used by ExcelJS is in any way compatable with the original. So I've added a workaround to copy the theme files
Could you check whether this resolves your issue?

@Rycochet
Copy link
Contributor Author

Looks good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants