Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #899 Support for inserting pictures with hyperlinks #1071

Merged
merged 4 commits into from Jan 22, 2020
Merged

fix issue #899 Support for inserting pictures with hyperlinks #1071

merged 4 commits into from Jan 22, 2020

Conversation

Alanscut
Copy link
Member

Changes

  1. The purpose of this PR is to support inserting pictures with hyperlinks.
  2. fix for Is there any way to embed an image with hyperlink #899.

Please let me know if anything is needed for this PR.

@guyonroche
Copy link
Collaborator

@Alanscut Wow! Great work here. Can I ask you for two more changes?

  1. Add/amend the README.md file showing how to add images with hyperlinks
  2. Add an integration test that creates a new workbook containing an image with hyperlink and confirming that when the file is read back, it is as expected. spec/integration/workbook/images.spec.js has examples of how this is done

@Alanscut
Copy link
Member Author

@guyonroche Thanks your review! Have added the testcase and update README file as you instructed.

@guyonroche guyonroche merged commit 7721e0b into exceljs:master Jan 22, 2020
@Alanscut Alanscut mentioned this pull request Jan 23, 2020
Closed
@Alanscut Alanscut deleted the issue_899 branch May 5, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alanscut @guyonroche