Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing FillPattern fgColor should be optional #1550

Merged
merged 1 commit into from Feb 14, 2021
Merged

Typing FillPattern fgColor should be optional #1550

merged 1 commit into from Feb 14, 2021

Conversation

Andries-Smit
Copy link
Contributor

Summary

Using typescript the FillPattern the fgColor should be optional.

This is described in the documentation https://github.com/exceljs/exceljs/blame/master/README.md#L1722

@Andries-Smit Andries-Smit changed the title Typing FillPattern is optional Typing FillPattern fgColor should be optional Dec 3, 2020
@Siemienik Siemienik self-requested a review February 12, 2021 02:30
Siemienik
Siemienik approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you. LGTM:+1:

I'm contributing ExcelJS just for fun. If want you to know something more go into #1500

@Siemienik Siemienik merged commit 20450dc into exceljs:master Feb 14, 2021
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Andries-Smit @Siemienik