Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TS declarations of Workbook properties #1656

Merged
merged 2 commits into from Apr 11, 2021
Merged

Add TS declarations of Workbook properties #1656

merged 2 commits into from Apr 11, 2021

Conversation

kaoths
Copy link
Contributor

@kaoths kaoths commented Apr 8, 2021

Summary

Related to #1655

Test plan

Try to set Workbook's properties e.g. workbook.title = 'some title'; should not throw TS2339

Siemienik
Siemienik approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixation 🏅 LGTM. Thank you!

@Siemienik Siemienik merged commit a0b4583 into exceljs:master Apr 11, 2021
@Siemienik Siemienik mentioned this pull request Apr 11, 2021
Closed
@anhhung26051998
Copy link

anhhung26051998 commented Aug 23, 2021 •
edited

Cannot get text in cell DataType = Date
when load file libary auto convert cell to Datetime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaoths @anhhung26051998 @Siemienik