Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic size for comment box #1933

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

csgka1
Copy link

@csgka1 csgka1 commented Dec 18, 2021

Summary

Add a feature to solve issue #981 (#1493 ).

This PR add a option for comment. With that option the comment can be set Automatic Size property.
usage:

sheet.getCell('C3').comment = {
    texts: ['This\nIs\nA\nComment\nThat\nNeed\nA\nLarge\nBox'],
    autoShape: true,  // with this option the size of comment box will be adjusted automatically
 };

The corresponding setting in excel is in the screenshot below:

image

Test plan

npm i && npm run test:all

All test cases has passed.

Questions

Should I update README.MD at the same time?

@csgka1 csgka1 changed the title Feature/comment auto shape Add automatic size for comment box Dec 18, 2021
Copy link

@sathish-karunakaran sathish-karunakaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Siemienik Siemienik self-assigned this Apr 6, 2023
@zurmokeeper
Copy link
Contributor

@csgka1 Could you please move over here? I'd be happy to merge this feature.

@timo-kauranen
Copy link

could this be merged, pretty please 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants