Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type definitions about last column, formula values and protection #2309

Merged
merged 4 commits into from Sep 19, 2023

Conversation

gltjk
Copy link
Contributor

@gltjk gltjk commented Jul 18, 2023

Summary

Several type definition has been fixed. Details:

  • Worksheet.lastColumn can be undefined for an empty worksheet, as Worksheet.lastRow can be undefined.
  • date1904 should be an optional property for both CellFormulaValue and CellSharedFormulaValue.
  • CellFormulaValue.result and CellSharedFormulaValue.result should include boolean.
  • CellFormulaValue.result and CellSharedFormulaValue.result should include CellErrorValue, not { error: CellErrorValue }, because CellErrorValue itself is already an interface with error as its property.
  • Protection should have a hidden property, as is recorded in the documentation.
  • dashed should be a valid value for BorderStyle, as is documented in ISO/IEC 29500-1:2016 18.18.3 ST_BorderStyle (Border Line Styles).

Test plan

Related to source code (for typings update)

Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Siemienik Siemienik merged commit bd317db into exceljs:master Sep 19, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants