Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default width generates 1x1 image #28

Closed
sophietk opened this issue Sep 22, 2015 · 3 comments
Closed

Default width generates 1x1 image #28

sophietk opened this issue Sep 22, 2015 · 3 comments

Comments

@sophietk
Copy link
Contributor

Hi,

The plugin allowed specifying only width -or height- to maintain the aspect ratio of the image. Now, that causes the generated image size to be 1x1.

Since the commit aheckmann/gm@781fb82 changes the gm resize implementation, a 0-value is considered as a valid width/height. The grunt-image-resize should not provide '0' as default value anymore. Instead '' (empty string) should do the job.

@pattiereaves
Copy link

@sophietk THANK YOU THANK YOU THANK YOU. I had this problem for weeks and had no idea what the issue was. You need to pass an empty string for height, too.

sophietk added a commit to sophietk/grunt-image-resize that referenced this issue Oct 31, 2015
@nadnoslen
Copy link

Yes thank you @sophietk. This issue got me a month ago and had me vexed. I think we all need to find a new library considering this one is no longer being maintained.

@thebiltheory
Copy link

@sophietk Sank U !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants