-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default width generates 1x1 image #28
Comments
@sophietk THANK YOU THANK YOU THANK YOU. I had this problem for weeks and had no idea what the issue was. You need to pass an empty string for height, too. |
sophietk
added a commit
to sophietk/grunt-image-resize
that referenced
this issue
Oct 31, 2015
- fixes excellenteasy#28 - bug due to new gm implementation: aheckmann/gm@781fb82
Yes thank you @sophietk. This issue got me a month ago and had me vexed. I think we all need to find a new library considering this one is no longer being maintained. |
@sophietk Sank U ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
The plugin allowed specifying only width -or height- to maintain the aspect ratio of the image. Now, that causes the generated image size to be 1x1.
Since the commit aheckmann/gm@781fb82 changes the gm resize implementation, a 0-value is considered as a valid width/height. The grunt-image-resize should not provide '0' as default value anymore. Instead '' (empty string) should do the job.
The text was updated successfully, but these errors were encountered: