Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Skull Creations to ItemStack #5

Closed
0xLyptox opened this issue Jun 9, 2019 · 4 comments
Closed

Missing Skull Creations to ItemStack #5

0xLyptox opened this issue Jun 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@0xLyptox
Copy link

0xLyptox commented Jun 9, 2019

Please update your Items-Module within the ItemStack Class to create custom Skulls.
Missing Methods:

  • *void setOwner(String owner)
  • *String getOwner()
  • boolean isSkull()

Thanks

@Exceptionflug
Copy link
Owner

Exceptionflug commented Jun 9, 2019

Hey thanks for your interest,

one question. What do you want to get returned by isSkull? True if the ItemType is PLAYER_HEAD or true if the ItemType is any skull type like SKELETON_SKULL?

@Exceptionflug Exceptionflug added the enhancement New feature or request label Jun 9, 2019
@0xLyptox
Copy link
Author

0xLyptox commented Jun 9, 2019

Hey,

If the ItemType is an PLAYER_HEAD i mean.
Edit: You can rename it to isPlayerSkull()

@Exceptionflug
Copy link
Owner

Please take a look at 18448a7
These changes will be part of the next scheduled release v1.4.4 after Minecraft 1.14.3 releases. If you want to use those methods now, you have to manually build your own version of Protocolize using Maven.

@0xLyptox
Copy link
Author

0xLyptox commented Jun 9, 2019

Thank you

@0xLyptox 0xLyptox closed this as completed Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants