Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Microsoft.Extensions.PlatformAbstractions #315

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

niemyjski
Copy link
Member

This removes .NET Platform 1.0 and 1.1 only supported apis from the core netstandard client.

There is a slight change in behavior as I'm trying to reuse some existing logic to smartly detect the entry assembly and exclude Exceptionless and Microsoft Packages (We could use this in a few more spots but wanted to keep this minimal). Here is the diff before using the new GetEntryAssembly helper (which picks a different assembly as our samples start with Exceptionless...)

image

@niemyjski niemyjski requested a review from ejsmith March 28, 2024 13:10
@niemyjski niemyjski self-assigned this Mar 28, 2024
@niemyjski niemyjski merged commit 917e235 into main Mar 28, 2024
7 checks passed
@niemyjski niemyjski deleted the feature/remove-deprecated-dep branch March 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants